Remove SelectionRootBoundsChanged from render_widget_host_view_efl.hi/cc
authorAntonio Gomes <a1.gomes@sisa.samsung.com>
Wed, 30 Jul 2014 13:00:40 +0000 (09:00 -0400)
committerYoungsoo Choi <kenshin.choi@samsung.com>
Tue, 10 Jul 2018 06:57:09 +0000 (06:57 +0000)
In chromium, this method used to be implemented
in render_widget_host_view_base.h (base class)
under a OS_ANDROID build guard, but was removed
by r273628 [1].

Commit message (of the removal):

"
Revert of Chromium plumbing to use the selection root bounds. (https://codereview.chromium.org/186753002/)

Reason for revert:
The Android plumbing to use the root selection bounds has been removed, and the
visibility calculation will soon be performed by the compositor
(see crbug.com/135959).
(...)
https://codereview.chromium.org/306803002
"

tizen_src/impl/browser/renderer_host/render_widget_host_view_efl.cc
tizen_src/impl/browser/renderer_host/render_widget_host_view_efl.h

index 238c9f2f311e12bed0f47ddd07954bc787f7e052..2b30a4e055542824e6d9ab1a496cf3845d148938 100644 (file)
@@ -635,12 +635,6 @@ void RenderWidgetHostViewEfl::ScrollOffsetChanged() {
   NOTIMPLEMENTED();
 }
 
-void RenderWidgetHostViewEfl::SelectionRootBoundsChanged(const gfx::Rect& rect) {
-  if (GetSelectionController())
-    GetSelectionController()->SetVisibilityBounds(
-      ConvertRectToPixel(device_scale_factor_, rect));
-}
-
 void RenderWidgetHostViewEfl::DidStopFlinging() {
 #ifdef TIZEN_EDGE_EFFECT
   web_view_->edgeEffect()->hide();
index c5d7fcc042aa84f13df65fe6547fd6b169c3b855..8669ab1f6c704e9a7bab7fa6541299374a85b0bb 100644 (file)
@@ -104,7 +104,6 @@ class RenderWidgetHostViewEfl
   virtual void SetTooltipText(const base::string16&) OVERRIDE;
   virtual void SelectionChanged(const base::string16&, size_t, const gfx::Range&) OVERRIDE;
   virtual void SelectionBoundsChanged(const ViewHostMsg_SelectionBounds_Params&) OVERRIDE;
-  virtual void SelectionRootBoundsChanged(const gfx::Rect&) OVERRIDE;
   virtual void ScrollOffsetChanged() OVERRIDE;
   virtual void CopyFromCompositingSurface(
     const gfx::Rect&,