net/mlx5e: Extract creation of rep's default flow rule
authorGavi Teitz <gavi@mellanox.com>
Sun, 19 Aug 2018 11:08:27 +0000 (14:08 +0300)
committerSaeed Mahameed <saeedm@mellanox.com>
Mon, 1 Oct 2018 18:32:43 +0000 (11:32 -0700)
Cleaning up the flow of the representors' rx initialization, towards
enabling RSS for the representors.

Signed-off-by: Gavi Teitz <gavi@mellanox.com>
Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c

index 08ba206..8494687 100644 (file)
@@ -1003,13 +1003,25 @@ static void mlx5e_init_rep(struct mlx5_core_dev *mdev,
        mlx5e_timestamp_init(priv);
 }
 
-static int mlx5e_init_rep_rx(struct mlx5e_priv *priv)
+static int mlx5e_create_rep_vport_rx_rule(struct mlx5e_priv *priv)
 {
        struct mlx5_eswitch *esw = priv->mdev->priv.eswitch;
        struct mlx5e_rep_priv *rpriv = priv->ppriv;
        struct mlx5_eswitch_rep *rep = rpriv->rep;
-       struct mlx5_core_dev *mdev = priv->mdev;
        struct mlx5_flow_handle *flow_rule;
+
+       flow_rule = mlx5_eswitch_create_vport_rx_rule(esw,
+                                                     rep->vport,
+                                                     priv->direct_tir[0].tirn);
+       if (IS_ERR(flow_rule))
+               return PTR_ERR(flow_rule);
+       rpriv->vport_rx_rule = flow_rule;
+       return 0;
+}
+
+static int mlx5e_init_rep_rx(struct mlx5e_priv *priv)
+{
+       struct mlx5_core_dev *mdev = priv->mdev;
        int err;
 
        mlx5e_init_l2_addr(priv);
@@ -1028,14 +1040,9 @@ static int mlx5e_init_rep_rx(struct mlx5e_priv *priv)
        if (err)
                goto err_destroy_direct_rqts;
 
-       flow_rule = mlx5_eswitch_create_vport_rx_rule(esw,
-                                                     rep->vport,
-                                                     priv->direct_tir[0].tirn);
-       if (IS_ERR(flow_rule)) {
-               err = PTR_ERR(flow_rule);
+       err = mlx5e_create_rep_vport_rx_rule(priv);
+       if (err)
                goto err_destroy_direct_tirs;
-       }
-       rpriv->vport_rx_rule = flow_rule;
 
        return 0;