ext4: avoid bh leak in retry path of ext4_expand_extra_isize_ea()
authorTheodore Ts'o <tytso@mit.edu>
Fri, 1 Nov 2013 03:00:24 +0000 (23:00 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Dec 2013 19:05:25 +0000 (11:05 -0800)
commit dcb9917ba041866686fe152850364826c4622a36 upstream.

Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/xattr.c

index 03e9beb..1423c48 100644 (file)
@@ -1352,6 +1352,7 @@ retry:
                                        new_extra_isize = s_min_extra_isize;
                                        kfree(is); is = NULL;
                                        kfree(bs); bs = NULL;
+                                       brelse(bh);
                                        goto retry;
                                }
                                error = -1;