io_uring: fix clear IORING_SETUP_R_DISABLED in wrong function
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 15 Jul 2021 13:18:25 +0000 (21:18 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jul 2021 07:45:02 +0000 (09:45 +0200)
In commit 3ebba796fa25 ("io_uring: ensure that SQPOLL thread is started for exit"),
the IORING_SETUP_R_DISABLED is cleared in io_sq_offload_start(), but when backport
it to stable-5.10, IORING_SETUP_R_DISABLED is cleared in __io_req_task_submit(),
move clearing IORING_SETUP_R_DISABLED to io_sq_offload_start() to fix this.

Fixes: 6cae8095490ca ("io_uring: ensure that SQPOLL thread is started for exit")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/io_uring.c

index fb63cc8..4215310 100644 (file)
@@ -2087,7 +2087,6 @@ static void __io_req_task_submit(struct io_kiocb *req)
                __io_req_task_cancel(req, -EFAULT);
        mutex_unlock(&ctx->uring_lock);
 
-       ctx->flags &= ~IORING_SETUP_R_DISABLED;
        if (ctx->flags & IORING_SETUP_SQPOLL)
                io_sq_thread_drop_mm();
 }
@@ -7992,6 +7991,7 @@ static void io_sq_offload_start(struct io_ring_ctx *ctx)
 {
        struct io_sq_data *sqd = ctx->sq_data;
 
+       ctx->flags &= ~IORING_SETUP_R_DISABLED;
        if ((ctx->flags & IORING_SETUP_SQPOLL) && sqd->thread)
                wake_up_process(sqd->thread);
 }