projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
ee7ce7d
)
RDMA/core: Fix double put of resource
author
Sasha Levin
<sashal@kernel.org>
Sun, 17 May 2020 01:47:57 +0000
(21:47 -0400)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 20 May 2020 06:20:26 +0000
(08:20 +0200)
[ Upstream commit
50bbe3d34fea74b7c0fabe553c40c2f4a48bb9c3
]
Do not decrease the reference count of resource tracker object twice in
the error flow of res_get_common_doit.
Fixes:
c5dfe0ea6ffa
("RDMA/nldev: Add resource tracker doit callback")
Link:
https://lore.kernel.org/r/20200507062942.98305-1-leon@kernel.org
Signed-off-by: Maor Gottlieb <maorg@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/core/nldev.c
patch
|
blob
|
history
diff --git
a/drivers/infiniband/core/nldev.c
b/drivers/infiniband/core/nldev.c
index
ef4b0c7
..
244ebf2
100644
(file)
--- a/
drivers/infiniband/core/nldev.c
+++ b/
drivers/infiniband/core/nldev.c
@@
-1248,10
+1248,10
@@
static int res_get_common_doit(struct sk_buff *skb, struct nlmsghdr *nlh,
has_cap_net_admin = netlink_capable(skb, CAP_NET_ADMIN);
ret = fe->fill_res_func(msg, has_cap_net_admin, res, port);
- rdma_restrack_put(res);
if (ret)
goto err_free;
+ rdma_restrack_put(res);
nlmsg_end(msg, nlh);
ib_device_put(device);
return rdma_nl_unicast(sock_net(skb->sk), msg, NETLINK_CB(skb).portid);