The target features are obtained as a list of features/attributes.
Instead of storing them in a single string, store the vector. This
matches lto::Config's behavior and simplifies the transition to
lto::backend().
Reviewed By: tejohnson
Differential Revision: https://reviews.llvm.org/D95224
void setFileType(CodeGenFileType FT) { FileType = FT; }
void setCpu(StringRef MCpu) { this->MCpu = std::string(MCpu); }
- void setAttr(StringRef MAttr) { this->MAttr = std::string(MAttr); }
+ void setAttrs(std::vector<std::string> MAttrs) { this->MAttrs = MAttrs; }
void setOptLevel(unsigned OptLevel);
void setShouldInternalize(bool Value) { ShouldInternalize = Value; }
std::vector<std::string> CodegenOptions;
std::string FeatureStr;
std::string MCpu;
- std::string MAttr;
+ std::vector<std::string> MAttrs;
std::string NativeObjectPath;
TargetOptions Options;
CodeGenOpt::Level CGOptLevel = CodeGenOpt::Default;
// Construct LTOModule, hand over ownership of module and target. Use MAttr as
// the default set of features.
- SubtargetFeatures Features(MAttr);
+ SubtargetFeatures Features(join(MAttrs, ""));
Features.getDefaultSubtargetFeatures(Triple);
FeatureStr = Features.getString();
// Set a default CPU for Darwin triples.
CodeGen.setCpu(codegen::getMCPU().c_str());
CodeGen.setOptLevel(OptLevel - '0');
-
- auto MAttrs = codegen::getMAttrs();
- if (!MAttrs.empty()) {
- std::string attrs = join(MAttrs, ",");
- CodeGen.setAttr(attrs);
- }
+ CodeGen.setAttrs(codegen::getMAttrs());
if (auto FT = codegen::getExplicitFileType())
CodeGen.setFileType(FT.getValue());
// Convert the subtarget features into a string to pass to LTOCodeGenerator.
static void lto_add_attrs(lto_code_gen_t cg) {
LTOCodeGenerator *CG = unwrap(cg);
- auto MAttrs = codegen::getMAttrs();
- if (!MAttrs.empty()) {
- std::string attrs = join(MAttrs, ",");
- CG->setAttr(attrs);
- }
+ CG->setAttrs(codegen::getMAttrs());
if (OptLevel < '0' || OptLevel > '3')
report_fatal_error("Optimization level must be between 0 and 3");