platform/chrome: cros_ec_proto: don't show MKBP version if unsupported
authorTzung-Bi Shih <tzungbi@kernel.org>
Thu, 9 Jun 2022 08:49:49 +0000 (08:49 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:40:30 +0000 (11:40 +0200)
[ Upstream commit b36f0643ff14a2fb281b105418e4e73c9d7c11d0 ]

It wrongly showed the following message when it doesn't support MKBP:
"MKBP support version 4294967295".

Fix it.

Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20220609084957.3684698-14-tzungbi@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/chrome/cros_ec_proto.c

index ed2b480..1575d60 100644 (file)
@@ -507,13 +507,13 @@ int cros_ec_query_all(struct cros_ec_device *ec_dev)
        ret = cros_ec_get_host_command_version_mask(ec_dev,
                                                    EC_CMD_GET_NEXT_EVENT,
                                                    &ver_mask);
-       if (ret < 0 || ver_mask == 0)
+       if (ret < 0 || ver_mask == 0) {
                ec_dev->mkbp_event_supported = 0;
-       else
+       } else {
                ec_dev->mkbp_event_supported = fls(ver_mask);
 
-       dev_dbg(ec_dev->dev, "MKBP support version %u\n",
-               ec_dev->mkbp_event_supported - 1);
+               dev_dbg(ec_dev->dev, "MKBP support version %u\n", ec_dev->mkbp_event_supported - 1);
+       }
 
        /* Probe if host sleep v1 is supported for S0ix failure detection. */
        ret = cros_ec_get_host_command_version_mask(ec_dev,