projects
/
platform
/
upstream
/
rpm.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7fe19f0
)
verifyDSASignature() buffer & other fixes
author
Panu Matilainen
<pmatilai@redhat.com>
Tue, 8 Apr 2008 10:27:59 +0000
(13:27 +0300)
committer
Panu Matilainen
<pmatilai@redhat.com>
Tue, 8 Apr 2008 10:27:59 +0000
(13:27 +0300)
- avoid stpcpy() into static sized buffer
- avoid potential sigp NULL-dereference
lib/signature.c
patch
|
blob
|
history
diff --git
a/lib/signature.c
b/lib/signature.c
index
c531e26
..
cf7aaf0
100644
(file)
--- a/
lib/signature.c
+++ b/
lib/signature.c
@@
-1245,6
+1245,9
@@
verifyDSASignature(rpmts ts, char ** msg,
const char *hdr;
int sigver;
+ assert(msg != NULL);
+ *msg = NULL;
+
hdr = (dig != NULL && dig->hdrsha1ctx == sha1ctx) ? _("Header ") : "";
sigver = sigp !=NULL ? sigp->version : 0;
@@
-1314,7
+1317,6
@@
exit:
rasprintf(msg, _("%sV%d DSA signature: %s\n"),
hdr, sigver, rpmSigString(res));
}
-
return res;
}