radv: Allow DCC & TC-compat HTILE with VK_IMAGE_CREATE_EXTENDED_USAGE_BIT.
authorBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Thu, 16 Jan 2020 01:33:35 +0000 (02:33 +0100)
committerMarge Bot <eric+marge@anholt.net>
Fri, 24 Jan 2020 11:16:39 +0000 (11:16 +0000)
I misunderstood the flag when initially disabling. But this flag
only does something with mutable formats. If we have DCC and
mutable formats, the formats are close enough that the allowed
usage flags are not meaningfully different nor used during
allocation.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3424>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3424>

src/amd/vulkan/radv_image.c

index 1640d9c..8992538 100644 (file)
@@ -72,8 +72,7 @@ radv_use_tc_compat_htile_for_image(struct radv_device *device,
        if (device->physical_device->rad_info.chip_class < GFX8)
                return false;
 
-       if ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) ||
-           (pCreateInfo->flags & VK_IMAGE_CREATE_EXTENDED_USAGE_BIT))
+       if ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT))
                return false;
 
        if (pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR)
@@ -159,8 +158,7 @@ radv_use_dcc_for_image(struct radv_device *device,
                return false;
 
        /* TODO: Enable DCC for storage images. */
-       if ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) ||
-           (pCreateInfo->flags & VK_IMAGE_CREATE_EXTENDED_USAGE_BIT))
+       if ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT))
                return false;
 
        if (pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR)