Bluetooth: hci_nokia: Save a few cycles in 'nokia_enqueue()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 19 Sep 2019 19:52:08 +0000 (21:52 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Wed, 16 Oct 2019 17:26:40 +0000 (19:26 +0200)
'skb_pad()' a few lines above already initializes the "padded" byte to 0.
So there is no need to do it twice.

All what is needed is to increase the len of the skb. So 'skb_put(..., 1)'
is enough here.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/hci_nokia.c

index 6463350..05f7f6d 100644 (file)
@@ -520,7 +520,7 @@ static int nokia_enqueue(struct hci_uart *hu, struct sk_buff *skb)
                err = skb_pad(skb, 1);
                if (err)
                        return err;
-               skb_put_u8(skb, 0x00);
+               skb_put(skb, 1);
        }
 
        skb_queue_tail(&btdev->txq, skb);