drm/i915/pps: use intel_de_rmw() for panel unlock

Use rmw where needed.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230417085742.793379-1-jani.nikula@intel.com

diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
index 7f9926672a6a58f89d58410aab12b6f5df7cbca6..4f0b0cca03ccac9ccf2670754e2e836e50601ec6 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_pps.c
+++ b/drivers/gpu/drm/i915/display/intel_pps.c
@@ -1653,12 +1653,9 @@ void intel_pps_unlock_regs_wa(struct drm_i915_private *dev_priv)
         */
        pps_num = intel_num_pps(dev_priv);
 
-       for (pps_idx = 0; pps_idx < pps_num; pps_idx++) {
-               u32 val = intel_de_read(dev_priv, PP_CONTROL(pps_idx));
-
-               val = (val & ~PANEL_UNLOCK_MASK) | PANEL_UNLOCK_REGS;
-               intel_de_write(dev_priv, PP_CONTROL(pps_idx), val);
-       }
+       for (pps_idx = 0; pps_idx < pps_num; pps_idx++)
+               intel_de_rmw(dev_priv, PP_CONTROL(pps_idx),
+                            PANEL_UNLOCK_MASK, PANEL_UNLOCK_REGS);
 }
 
 void intel_pps_setup(struct drm_i915_private *i915)