pulsesrc: don't discard the result of _set_caps()
authorWim Taymans <wim.taymans@collabora.co.uk>
Mon, 24 Aug 2009 14:22:47 +0000 (16:22 +0200)
committerWim Taymans <wim.taymans@collabora.co.uk>
Mon, 24 Aug 2009 14:22:47 +0000 (16:22 +0200)
Use the result of gst_pad_set_caps() instead of assuming success.

See #590678

ext/pulse/pulsesrc.c

index 8686407..fa60345 100644 (file)
@@ -926,8 +926,7 @@ gst_pulsesrc_negotiate (GstBaseSrc * basesrc)
         /* yay, fixed caps, use those then */
         result = gst_pulsesrc_create_stream (GST_PULSESRC_CAST (basesrc), caps);
         if (result)
-          gst_pad_set_caps (GST_BASE_SRC_PAD (basesrc), caps);
-        result = TRUE;
+          result = gst_pad_set_caps (GST_BASE_SRC_PAD (basesrc), caps);
       }
     }
     gst_caps_unref (caps);