Fix string copy issue in Credential resource unit test.
authorAnkur Bansal <ankur.b1@samsung.com>
Tue, 7 Jul 2015 07:26:56 +0000 (12:56 +0530)
committerSachin Agrawal <sachin.agrawal@intel.com>
Wed, 8 Jul 2015 21:18:13 +0000 (21:18 +0000)
Update getCredList to correctly pass length of destination buffer while
using OICStrcpy.

Change-Id: I4763d295fc1da92831956bf9ed4a34e90718c7f3
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1553
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
resource/csdk/security/unittest/credentialresource.cpp

index 13dfb12..fcbb3ac 100644 (file)
@@ -69,9 +69,9 @@ OicSecCred_t * getCredList()
     cred->next->roleIdsLen = 0;
 #endif
     cred->next->credType = 1;
-    cred->next->privateData.data = (char *)OICCalloc(1, strlen("My private Key21") + 1);
-    OICStrcpy(cred->next->privateData.data, sizeof(cred->next->privateData.data),
-            "My private Key21");
+    size_t data_size = strlen("My private Key21") + 1;
+    cred->next->privateData.data = (char *)OICCalloc(1, data_size);
+    OICStrcpy(cred->next->privateData.data, data_size,"My private Key21");
 #if 0
     cred->next->publicData.data = (char *)OICCalloc(1, strlen("My Public Key123") + 1);
     OICStrcpy(cred->next->publicData.data, sizeof(cred->next->publicData.data),"My Public Key123");