We need to avoid declaring dependencies on strings which are valid
LINK_LIBS and not valid targets. Previously, we used if(TARGET) to
check this condition. However, if(TARGET) checks whether a target has
been created (in the cmake subdirectory traversal order) and not
whether it *will* be created. This results in annoying directory
ordering problems.
This patch changes the check to more explicitly eliminate problematic
libraries (namely -lpthread) using a REGEX.
Differential Revision: https://reviews.llvm.org/D79837
"PUBLIC;PRIVATE"
${ARG_LINK_LIBS})
foreach(link_lib ${LINK_LIBS_ARG_PUBLIC})
- if(TARGET ${link_lib})
+ # Can't specify a dependence on -lpthread
+ if(NOT ${link_lib} MATCHES "-.*")
add_dependencies(${obj_name} ${link_lib})
endif()
endforeach()