spi: replace snprintf in show functions with sysfs_emit
authorQing Wang <wangqing@vivo.com>
Fri, 15 Oct 2021 06:51:08 +0000 (23:51 -0700)
committerMark Brown <broonie@kernel.org>
Fri, 15 Oct 2021 15:11:01 +0000 (16:11 +0100)
show() must not use snprintf() when formatting the value to be
returned to user space.

Fix the following coccicheck warning:
drivers/spi/spi-tle62x0.c:144: WARNING: use scnprintf or sprintf.

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Signed-off-by: Qing Wang <wangqing@vivo.com>
Link: https://lore.kernel.org/r/1634280668-4954-1-git-send-email-wangqing@vivo.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-tle62x0.c

index 60dc69a..f8ad070 100644 (file)
@@ -141,7 +141,7 @@ static ssize_t tle62x0_gpio_show(struct device *dev,
        value = (st->gpio_state >> gpio_num) & 1;
        mutex_unlock(&st->lock);
 
-       return snprintf(buf, PAGE_SIZE, "%d", value);
+       return sysfs_emit(buf, "%d", value);
 }
 
 static ssize_t tle62x0_gpio_store(struct device *dev,