watchdog: advantechwdt: mark expected switch fall-through
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Thu, 2 Nov 2017 19:21:36 +0000 (14:21 -0500)
committerWim Van Sebroeck <wim@iguana.be>
Thu, 28 Dec 2017 19:45:28 +0000 (20:45 +0100)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case I replaced "Fall" with a proper
"fall through" comment, which is what GCC is expecting to find.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/advantechwdt.c

index 7d7db0c..f619443 100644 (file)
@@ -181,7 +181,7 @@ static long advwdt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
                if (advwdt_set_heartbeat(new_timeout))
                        return -EINVAL;
                advwdt_ping();
-               /* Fall */
+               /* fall through */
        case WDIOC_GETTIMEOUT:
                return put_user(timeout, p);
        default: