ath10k: remove unnecessary code 78/292578/1
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 19 May 2017 08:54:00 +0000 (11:54 +0300)
committerSeung-Woo Kim <sw0312.kim@samsung.com>
Mon, 8 May 2023 09:39:38 +0000 (18:39 +0900)
The array fields in struct wmi_start_scan_arg that are checked here are
fixed size arrays so they can never be NULL.

Addresses-Coverity-ID: 1260031
Cc: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
[sw0312.kim: backport upstream commit 8c1f20815231 to resolve gcc-12 build issue]
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Change-Id: Ie7096cc6bd0bc8280c44bf124e49aa06e49b9bd9

drivers/net/wireless/ath/ath10k/wmi.c

index af3bc06..e635ea1 100644 (file)
@@ -5903,15 +5903,6 @@ static struct sk_buff *ath10k_wmi_10_4_op_gen_init(struct ath10k *ar)
 
 int ath10k_wmi_start_scan_verify(const struct wmi_start_scan_arg *arg)
 {
-       if (arg->ie_len && !arg->ie)
-               return -EINVAL;
-       if (arg->n_channels && !arg->channels)
-               return -EINVAL;
-       if (arg->n_ssids && !arg->ssids)
-               return -EINVAL;
-       if (arg->n_bssids && !arg->bssids)
-               return -EINVAL;
-
        if (arg->ie_len > WLAN_SCAN_PARAMS_MAX_IE_LEN)
                return -EINVAL;
        if (arg->n_channels > ARRAY_SIZE(arg->channels))