drm/radeon: use 0-255 rather than 0-100 for pwm fan range
authorAlex Deucher <alexander.deucher@amd.com>
Wed, 4 Feb 2015 22:18:55 +0000 (17:18 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 11 Feb 2015 17:01:33 +0000 (12:01 -0500)
0-255 seems to be the preferred range for the pwm interface.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/radeon_pm.c

index 91e1bd2..9f758d3 100644 (file)
@@ -585,7 +585,7 @@ static ssize_t radeon_hwmon_set_pwm1_enable(struct device *dev,
        if (err)
                return err;
 
-       switch(value) {
+       switch (value) {
        case 1: /* manual, percent-based */
                rdev->asic->dpm.fan_ctrl_set_mode(rdev, FDO_PWM_MODE_STATIC);
                break;
@@ -608,7 +608,7 @@ static ssize_t radeon_hwmon_get_pwm1_max(struct device *dev,
                                         struct device_attribute *attr,
                                         char *buf)
 {
-       return sprintf(buf, "%i\n", 100); /* pwm uses percent-based fan-control */
+       return sprintf(buf, "%i\n", 255);
 }
 
 static ssize_t radeon_hwmon_set_pwm1(struct device *dev,
@@ -623,6 +623,8 @@ static ssize_t radeon_hwmon_set_pwm1(struct device *dev,
        if (err)
                return err;
 
+       value = (value * 100) / 255;
+
        err = rdev->asic->dpm.set_fan_speed_percent(rdev, value);
        if (err)
                return err;
@@ -642,6 +644,8 @@ static ssize_t radeon_hwmon_get_pwm1(struct device *dev,
        if (err)
                return err;
 
+       speed = (speed * 255) / 100;
+
        return sprintf(buf, "%i\n", speed);
 }