Add modules to the heap only dump in order to have: (#19761)
authorchrisnas <chrisnas@users.noreply.github.com>
Sun, 2 Sep 2018 17:17:31 +0000 (19:17 +0200)
committerMike McLaughlin <mikem@microsoft.com>
Sun, 2 Sep 2018 17:17:31 +0000 (10:17 -0700)
+ types in with sos.dumpheap -stat instead of UNKNOWN
  + complete stack with sos.dumpstack On a dual core machine, full=11GB, withheap=226MB, withheap(+patch)=269MB

src/debug/createdump/crashinfo.cpp

index 8064691..6de6b94 100644 (file)
@@ -197,6 +197,10 @@ CrashInfo::GatherCrashInfo(MINIDUMP_TYPE minidumpType)
     // Add all the heap (read/write) memory regions (m_otherMappings contains the heaps)
     else if (minidumpType & MiniDumpWithPrivateReadWriteMemory)
     {
+        for (const MemoryRegion& region : m_moduleMappings)
+        {
+            InsertMemoryBackedRegion(region);
+        }
         for (const MemoryRegion& region : m_otherMappings)
         {
             if (region.Permissions() == (PF_R | PF_W))