s390/tape: use bitwise instead of arithmetic operator for flags
authorHaowen Bai <baihaowen@meizu.com>
Tue, 15 Mar 2022 08:53:41 +0000 (16:53 +0800)
committerVasily Gorbik <gor@linux.ibm.com>
Sun, 27 Mar 2022 20:18:38 +0000 (22:18 +0200)
This silences the following coccinelle warning:
drivers/s390/char/tape_34xx.c:360:38-39: WARNING: sum of probable bitmasks, consider |

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
Link: https://lore.kernel.org/r/1647334421-29989-1-git-send-email-baihaowen@meizu.com
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
drivers/s390/char/tape_34xx.c

index 7ada994..38cc156 100644 (file)
@@ -354,10 +354,10 @@ tape_34xx_unit_check(struct tape_device *device, struct tape_request *request,
        if ((
                sense[0] == SENSE_DATA_CHECK      ||
                sense[0] == SENSE_EQUIPMENT_CHECK ||
-               sense[0] == SENSE_EQUIPMENT_CHECK + SENSE_DEFERRED_UNIT_CHECK
+               sense[0] == (SENSE_EQUIPMENT_CHECK | SENSE_DEFERRED_UNIT_CHECK)
        ) && (
                sense[1] == SENSE_DRIVE_ONLINE ||
-               sense[1] == SENSE_BEGINNING_OF_TAPE + SENSE_WRITE_MODE
+               sense[1] == (SENSE_BEGINNING_OF_TAPE | SENSE_WRITE_MODE)
        )) {
                switch (request->op) {
                /*