display: Add omitted return value print 48/318048/1
authorYunhee Seo <yuni.seo@samsung.com>
Mon, 23 Sep 2024 04:46:32 +0000 (13:46 +0900)
committerYunhee Seo <yuni.seo@samsung.com>
Tue, 24 Sep 2024 04:21:17 +0000 (13:21 +0900)
In display logic, there was omitted return value in the log print.
Also, printing format is changed to keep log consistency and readability.

Change-Id: I73bedf9fc6b8795b8e50115db53e117430277252
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
src/deviced-display/deviced-display.c

index 194cdf35299803e4011a2867a1e5c82fa9dfc0ab..8fa7d3cedb45e436eaaf610b08b66a9fb3ee64c2 100644 (file)
@@ -85,7 +85,7 @@ static int lcd_on_procedure(enum syscommon_deviced_display_state state, enum dev
                                        DEVICED_POWER_ATTR_INT_DOZE_MODE,
                                        SYSCOMMON_DEVICED_POWER_DISABLE_DOZE_MODE);
        if (ret < 0)
-               _W("Disable power doze mode err(%d)", ret);
+               _W("Disable power doze mode ret(%d)", ret);
 
        _I("[lcdstep] reason: %s", syscommon_plugin_deviced_common_get_event_name(reason));
 
@@ -94,7 +94,7 @@ static int lcd_on_procedure(enum syscommon_deviced_display_state state, enum dev
                                        DEVICED_DISPLAY_ATTR_BOOL_BROADCASTED_FLAG,
                                        &lcd_on_broadcast);
        if (ret < 0)
-               _W("Cannot get lcd on broadcast flag err(%d)", ret);
+               _W("Cannot get lcd on broadcast flag ret(%d)", ret);
 
        if (!lcd_on_broadcast) {
                ret = syscommon_resman_set_resource_attr_uint64_2(SYSCOMMON_RESOURCE_ID(DEVICED_RESOURCE_TYPE_DISPLAY),
@@ -102,7 +102,7 @@ static int lcd_on_procedure(enum syscommon_deviced_display_state state, enum dev
                                        SYSCOMMON_DEVICED_DISPLAY_SIGNAL_PRE,
                                        reason);
                if (ret < 0)
-                       _W("Broadcast lcd on signal pre step err(%d)", ret);
+                       _W("Broadcast lcd on signal pre step ret(%d)", ret);
        }
 
        /* Update brightness as display brightness type */
@@ -111,14 +111,14 @@ static int lcd_on_procedure(enum syscommon_deviced_display_state state, enum dev
                                        DEVICED_DISPLAY_ATTR_INT_UPDATE_BRIGHTNESS,
                                        SYSCOMMON_DEVICED_DISPLAY_BRIGHTNESS_DIM);
                if (ret < 0) {
-                       _W("Cannot update brightness as dim brightness err(%d)", ret);
+                       _W("Cannot update brightness as dim brightness ret(%d)", ret);
                }
        } else if (state == SYSCOMMON_DEVICED_DISPLAY_STATE_ON) {
                ret = syscommon_resman_set_resource_attr_int(SYSCOMMON_RESOURCE_ID(DEVICED_RESOURCE_TYPE_DISPLAY),
                                        DEVICED_DISPLAY_ATTR_INT_UPDATE_BRIGHTNESS,
                                        SYSCOMMON_DEVICED_DISPLAY_BRIGHTNESS_DEFAULT);
                if (ret < 0) {
-                       _W("Cannot update brightness as default brightness err(%d)", ret);
+                       _W("Cannot update brightness as default brightness ret(%d)", ret);
                }
        }
 
@@ -128,7 +128,7 @@ static int lcd_on_procedure(enum syscommon_deviced_display_state state, enum dev
                                DEVICED_DISPLAY_ATTR_INT_PM_STATE,
                                SYSCOMMON_DEVICED_DISPLAY_STATE_DIM);
                if (ret < 0) {
-                       _E("Failed to set pm state as dim err(%d)", ret);
+                       _E("Failed to set pm state as dim ret(%d)", ret);
                        return ret;
                }
        } else if (state == SYSCOMMON_DEVICED_DISPLAY_STATE_ON) {
@@ -136,7 +136,7 @@ static int lcd_on_procedure(enum syscommon_deviced_display_state state, enum dev
                                        DEVICED_DISPLAY_ATTR_INT_PM_STATE,
                                        SYSCOMMON_DEVICED_DISPLAY_STATE_ON);
                if (ret < 0) {
-                       _E("Failed to set pm state as on err(%d)", ret);
+                       _E("Failed to set pm state as on ret(%d)", ret);
                        return ret;
                }
        }
@@ -151,7 +151,7 @@ static int lcd_on_procedure(enum syscommon_deviced_display_state state, enum dev
                                SYSCOMMON_DEVICED_DISPLAY_DEVICE_TYPE_DISPLAY,
                                reason);
        if (ret < 0) {
-               _E("Failed to start display device err(%d)", ret);
+               _E("Failed to start display device ret(%d)", ret);
                return ret;
        }
        ret = syscommon_resman_set_resource_attr_uint64_2(SYSCOMMON_RESOURCE_ID(DEVICED_RESOURCE_TYPE_DISPLAY),
@@ -159,14 +159,14 @@ static int lcd_on_procedure(enum syscommon_deviced_display_state state, enum dev
                                SYSCOMMON_DEVICED_DISPLAY_DEVICE_TYPE_TOUCHSCREEN,
                                reason);
        if (ret < 0) {
-               _W("Cannot start touchscreen device err(%d)");
+               _W("Cannot start touchscreen device ret(%d)", ret);
        }
        ret = syscommon_resman_set_resource_attr_uint64_2(SYSCOMMON_RESOURCE_ID(DEVICED_RESOURCE_TYPE_DISPLAY),
                                DEVICED_DISPLAY_ATTR_TUPLE2_START_DEPENDENT_DEVICE,
                                SYSCOMMON_DEVICED_DISPLAY_DEVICE_TYPE_TOUCHKEY,
                                reason);
        if (ret < 0) {
-               _W("Cannot start touchkey device err(%d)");
+               _W("Cannot start touchkey device ret(%d)", ret);
        }
 
        /* Broadcast lcd on complete signal */
@@ -180,10 +180,10 @@ static int lcd_on_procedure(enum syscommon_deviced_display_state state, enum dev
                                        DEVICED_DISPLAY_ATTR_BOOL_BROADCASTED_FLAG,
                                        true);
                                if (ret < 0) {
-                                       _W("Broadcast flag setting as true err(%d)", ret);
+                                       _W("Broadcast flag setting as true ret(%d)", ret);
                                }
                } else if (ret < 0) {
-                       _W("Broadcast lcd on signal post step err(%d)", ret);
+                       _W("Broadcast lcd on signal post step ret(%d)", ret);
                }
        }
 
@@ -192,13 +192,13 @@ static int lcd_on_procedure(enum syscommon_deviced_display_state state, enum dev
                                DEVICED_TOUCHLED_ATTR_INT_BACKLIGHT,
                                SYSCOMMON_DEVICED_TOUCHLED_DIRECT_ON);
        if (ret < 0)
-               _W("Enable key backlight as touchled direct on err(%d)", ret);
+               _W("Enable key backlight as touchled direct on ret(%d)", ret);
 
        ret = syscommon_resman_set_resource_attr_int(SYSCOMMON_RESOURCE_ID(DEVICED_RESOURCE_TYPE_DISPLAY),
                                DEVICED_DISPLAY_ATTR_INT_TOUCH_EVENT_BLOCKED,
                                false);
        if (ret < 0)
-               _W("Set touch event blocked as false err(%d)", ret);
+               _W("Set touch event blocked as false ret(%d)", ret);
 
        return 0;
 }
@@ -219,7 +219,7 @@ static int setup_display_with_dpms_init(void *data)
                                        (u_int64_t *) &state,
                                        (u_int64_t *) &normal_state_timeout);
        if (ret < 0) {
-               _E("Failed to get display normal state timeout, err(%d)", ret);
+               _E("Failed to get display normal state timeout, ret(%d)", ret);
                return ret;
        }
 
@@ -227,7 +227,7 @@ static int setup_display_with_dpms_init(void *data)
                                        DEVICED_DISPLAY_ATTR_INT_PM_CURRENT_STATE,
                                        SYSCOMMON_DEVICED_DISPLAY_STATE_ON);
        if (ret < 0) {
-               _E("Failed to set current state, err(%d)", ret);
+               _E("Failed to set current state, ret(%d)", ret);
                return ret;
        }
 
@@ -235,7 +235,7 @@ static int setup_display_with_dpms_init(void *data)
                                        DEVICED_DISPLAY_ATTR_INT_RESET_STATE_TIMEOUT,
                                        normal_state_timeout);
        if (ret < 0) {
-               _E("Failed to reset state timeout as normal state timeout value, err(%d)", ret);
+               _E("Failed to reset state timeout as normal state timeout value, ret(%d)", ret);
                return ret;
        }