net: stmmac: remove set but unused mask in stmmac_ethtool_set_link_ksettings()
authorVladimir Oltean <vladimir.oltean@nxp.com>
Thu, 6 Apr 2023 12:54:12 +0000 (15:54 +0300)
committerJakub Kicinski <kuba@kernel.org>
Sat, 8 Apr 2023 03:04:03 +0000 (20:04 -0700)
This was never used since the commit that added it - e58bb43f5e43
("stmmac: initial support to manage pcs modes").

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230406125412.48790-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c

index 35c8dd9..2ae73ab 100644 (file)
@@ -393,19 +393,10 @@ stmmac_ethtool_set_link_ksettings(struct net_device *dev,
 
        if (priv->hw->pcs & STMMAC_PCS_RGMII ||
            priv->hw->pcs & STMMAC_PCS_SGMII) {
-               u32 mask = ADVERTISED_Autoneg | ADVERTISED_Pause;
-
                /* Only support ANE */
                if (cmd->base.autoneg != AUTONEG_ENABLE)
                        return -EINVAL;
 
-               mask &= (ADVERTISED_1000baseT_Half |
-                       ADVERTISED_1000baseT_Full |
-                       ADVERTISED_100baseT_Half |
-                       ADVERTISED_100baseT_Full |
-                       ADVERTISED_10baseT_Half |
-                       ADVERTISED_10baseT_Full);
-
                mutex_lock(&priv->lock);
                stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, priv->hw->ps, 0);
                mutex_unlock(&priv->lock);