entry no longer completely breaks focus by focusing itself on selection signal

I don't know why this was added, but it breaks the ability to set focus on any widgets at all under some circumstances. it also is nonsensical since you should never need to set focus while selecting because:

* you are selecting with the mouse button, thereby having previously triggered focus from the mouse click

* you are selecting using api, in which case there's a config option to allow retaining selection which is also conceptually broken by this behavior

@fix

diff --git a/legacy/elementary/src/lib/elm_entry.c b/legacy/elementary/src/lib/elm_entry.c
index fd21682..50ac4c1 100644 (file)
--- a/legacy/elementary/src/lib/elm_entry.c
+++ b/legacy/elementary/src/lib/elm_entry.c
@@ -1921,7 +1921,6 @@ _entry_selection_start_signal_cb(void *data,
    const char *txt = elm_entry_selection_get(data);
    Evas_Object *top;
 
-   if (!elm_object_focus_get(data)) elm_object_focus_set(data, EINA_TRUE);
    EINA_LIST_FOREACH(entries, l, entry)
      {
         if (entry != data) elm_entry_select_none(entry);