Pass the LLVMTypeConverter by reference in UnrankedMemRefBuilder (NFC)
authorMehdi Amini <joker.eph@gmail.com>
Sat, 1 Jan 2022 02:01:41 +0000 (02:01 +0000)
committerMehdi Amini <joker.eph@gmail.com>
Sat, 1 Jan 2022 02:01:41 +0000 (02:01 +0000)
This is a fairly large structure (952B according to Coverity), it was
already passed by reference in most places but not consistently.

mlir/include/mlir/Conversion/LLVMCommon/MemRefBuilder.h
mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp

index 8f755d5..26c9df2 100644 (file)
@@ -219,7 +219,7 @@ public:
                            LLVM::LLVMPointerType elemPtrPtrType);
   /// Builds IR extracting the size[index] from the descriptor.
   static Value size(OpBuilder &builder, Location loc,
-                    LLVMTypeConverter typeConverter, Value sizeBasePtr,
+                    LLVMTypeConverter &typeConverter, Value sizeBasePtr,
                     Value index);
   /// Builds IR inserting the size[index] into the descriptor.
   static void setSize(OpBuilder &builder, Location loc,
index edb43b3..4f78461 100644 (file)
@@ -478,7 +478,7 @@ Value UnrankedMemRefDescriptor::sizeBasePtr(
 }
 
 Value UnrankedMemRefDescriptor::size(OpBuilder &builder, Location loc,
-                                     LLVMTypeConverter typeConverter,
+                                     LLVMTypeConverter &typeConverter,
                                      Value sizeBasePtr, Value index) {
   Type indexPtrTy = LLVM::LLVMPointerType::get(typeConverter.getIndexType());
   Value sizeStoreGep = builder.create<LLVM::GEPOp>(loc, indexPtrTy, sizeBasePtr,