netfilter: nf_queue: remove excess nf_bridge variable
authorPavel Tikhomirov <ptikhomirov@virtuozzo.com>
Thu, 11 Jan 2024 15:06:38 +0000 (23:06 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jan 2024 23:35:59 +0000 (15:35 -0800)
[ Upstream commit aeaa44075f8e49e2e0ad4507d925e690b7950145 ]

We don't really need nf_bridge variable here. And nf_bridge_info_exists
is better replacement for nf_bridge_info_get in case we are only
checking for existence.

Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Stable-dep-of: 9874808878d9 ("netfilter: bridge: replace physindev with physinif in nf_bridge_info")
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/netfilter/nf_queue.c

index 63d1516..3dfcb3a 100644 (file)
@@ -82,10 +82,8 @@ static void __nf_queue_entry_init_physdevs(struct nf_queue_entry *entry)
 {
 #if IS_ENABLED(CONFIG_BRIDGE_NETFILTER)
        const struct sk_buff *skb = entry->skb;
-       struct nf_bridge_info *nf_bridge;
 
-       nf_bridge = nf_bridge_info_get(skb);
-       if (nf_bridge) {
+       if (nf_bridge_info_exists(skb)) {
                entry->physin = nf_bridge_get_physindev(skb);
                entry->physout = nf_bridge_get_physoutdev(skb);
        } else {