fixed to convert Result issue related OC_EH_VALID, OC_STACK_SLOW_RESOURCE
authorjihwan.seo <jihwan.seo@samsung.com>
Fri, 19 Aug 2016 07:52:41 +0000 (16:52 +0900)
committerAshok Babu Channa <ashok.channa@samsung.com>
Wed, 24 Aug 2016 12:01:57 +0000 (12:01 +0000)
when return value in entity handler is set OC_EH_VALID, OC_EH_SLOW,
Error response was sent automatically.

Change-Id: Ica8042aab4e91ec8d276cde1ee2b8e6cd4216997
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10779
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
resource/csdk/stack/src/ocresource.c
resource/csdk/stack/src/ocserverrequest.c
resource/csdk/stack/src/ocstack.c

index 42b1e24..ff04990 100755 (executable)
@@ -473,6 +473,8 @@ OCStackResult EntityHandlerCodeToOCStackCode(OCEntityHandlerResult ehResult)
     switch (ehResult)
     {
         case OC_EH_OK:
+        case OC_EH_CONTENT:
+        case OC_EH_VALID:
             result = OC_STACK_OK;
             break;
         case OC_EH_SLOW:
index 3be4a73..8c825e4 100644 (file)
@@ -442,7 +442,9 @@ CAResponseResult_t ConvertEHResultToCAResult (OCEntityHandlerResult result, OCMe
         case OC_EH_SLOW: // 2.05
             caResult = CA_CONTENT;
             break;
-        case OC_EH_OK: // 2.04/2.05
+        case OC_EH_OK:
+        case OC_EH_CHANGED: // 2.04
+        case OC_EH_CONTENT: // 2.05
             if (method == OC_REST_POST || method == OC_REST_PUT)
             {
                 caResult = CA_CHANGED;
@@ -455,9 +457,6 @@ CAResponseResult_t ConvertEHResultToCAResult (OCEntityHandlerResult result, OCMe
         case OC_EH_VALID: // 2.03
             caResult = CA_VALID;
             break;
-        case OC_EH_CHANGED: // 2.04
-            caResult = CA_CHANGED;
-            break;
         // Unsuccessful Client Request
         case OC_EH_UNAUTHORIZED_REQ: // 4.01
             caResult = CA_UNAUTHORIZED_REQ;
index 88e5677..1804050 100644 (file)
@@ -4771,6 +4771,7 @@ bool OCResultToSuccess(OCStackResult ocResult)
         case OC_STACK_RESOURCE_DELETED:
         case OC_STACK_CONTINUE:
         case OC_STACK_RESOURCE_CHANGED:
+        case OC_STACK_SLOW_RESOURCE:
             return true;
         default:
             return false;