Revert remaining half of "gallium/dri2: Pass the resource that corresponds to the...
authorLucas Stach <l.stach@pengutronix.de>
Tue, 13 Apr 2021 14:42:57 +0000 (16:42 +0200)
committerMarge Bot <eric+marge@anholt.net>
Tue, 13 Apr 2021 16:40:04 +0000 (16:40 +0000)
As documented in 6ec7e0d40664 (gallium: document convention for get_handle
calls on multi-planar resources) it's the drivers responsibility to walk
the chain of resources for multi-planar resources. The get_handle interface
should always be called with the base resource by the frontend.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Acked-by: Simon Ser <contact@emersion.fr>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10212>

src/gallium/frontends/dri/dri2.c

index 781ddcb..5969871 100644 (file)
@@ -1167,12 +1167,8 @@ dri2_query_image_by_resource_handle(__DRIimage *image, int attrib, int *value)
    if (image->use & __DRI_IMAGE_USE_BACKBUFFER)
       usage |= PIPE_HANDLE_USAGE_EXPLICIT_FLUSH;
 
-   for (i = 0, tex = image->texture; tex; i++, tex = tex->next)
-      if (i == image->plane)
-          break;
-   assert(tex);
-
-   if (!pscreen->resource_get_handle(pscreen, NULL, tex, &whandle, usage))
+   if (!pscreen->resource_get_handle(pscreen, NULL, image->texture,
+                                     &whandle, usage))
       return false;
 
    switch (attrib) {