staging: ks7010: use ether_addr_copy() instead of custom copy
authorSergio Paracuellos <sergio.paracuellos@gmail.com>
Tue, 24 Apr 2018 13:50:02 +0000 (15:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Apr 2018 13:50:19 +0000 (15:50 +0200)
In order to achieve ethernet address copies, ether_addr_copy()
function exists. So just use it and avoid the byte by byte copy.
This increase readability.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ks7010/ks_wlan_net.c

index 81d66ac..aaa57c2 100644 (file)
@@ -2686,14 +2686,7 @@ int ks_wlan_net_start(struct net_device *dev)
 
        /* dummy address set */
        memcpy(priv->eth_addr, dummy_addr, ETH_ALEN);
-       dev->dev_addr[0] = priv->eth_addr[0];
-       dev->dev_addr[1] = priv->eth_addr[1];
-       dev->dev_addr[2] = priv->eth_addr[2];
-       dev->dev_addr[3] = priv->eth_addr[3];
-       dev->dev_addr[4] = priv->eth_addr[4];
-       dev->dev_addr[5] = priv->eth_addr[5];
-       dev->dev_addr[6] = 0x00;
-       dev->dev_addr[7] = 0x00;
+       ether_addr_copy(dev->dev_addr, priv->eth_addr);
 
        /* The ks_wlan-specific entries in the device structure. */
        dev->netdev_ops = &ks_wlan_netdev_ops;