Fixed Coverity Issues.

More fixes and review comment addressesd.

Change-Id: I96d1123b5342425df94fbcb8cac0dad89d14ded7
Signed-off-by: Randeep Singh <randeep.s@samsung.com>

diff --git a/bt_roaming_agent/src/bt_server.c b/bt_roaming_agent/src/bt_server.c
index 55b41a3..126a420 100755 (executable)
--- a/bt_roaming_agent/src/bt_server.c
+++ b/bt_roaming_agent/src/bt_server.c
@@ -190,6 +190,7 @@ __receive_finished(bt_server_t *server)
 
                server->active_timer_id = 0;
                __bt_send_data(server->client_socket_fd, NULL);
+               free(tlvReqB64);
                return;
        }
 
@@ -210,6 +211,7 @@ __receive_finished(bt_server_t *server)
        server->client_req = NULL;
        server->client_req_len = 0;
        server->client_socket_fd = -1;
+       free(tlvReqB64);
 
        return;
 }

diff --git a/common/cryptoutil/src/AsmCrypto.cpp b/common/cryptoutil/src/AsmCrypto.cpp
index ef6683f..f5bbf3d 100755 (executable)
--- a/common/cryptoutil/src/AsmCrypto.cpp
+++ b/common/cryptoutil/src/AsmCrypto.cpp
@@ -681,7 +681,7 @@ AsmCrypto::ToBase64Url(const unsigned char *input, int inputLen)
        {
                _ERR("Failed to encode base64.");
                free(output);
-               return (unsigned char*)"";
+               return (unsigned char *)strdup("");
        }
 
        _INFO("AsmCrypto::ToBase64Url::output size = [%d]", outputSz);

diff --git a/server/auth_discovery/src/BoundADProvider.cpp b/server/auth_discovery/src/BoundADProvider.cpp
index 606debd..6ac29c0 100755 (executable)
--- a/server/auth_discovery/src/BoundADProvider.cpp
+++ b/server/auth_discovery/src/BoundADProvider.cpp
@@ -330,7 +330,7 @@ BoundADProvider::loadPlugins(const std::string& dirName)
                                __stubCache->insert(std::make_pair(auth_plugin->id, stub));
 
                        }*/
-                       dlclose(mod);
+                       if (mod) dlclose(mod);
                }
        }
 

diff --git a/server/states/src/AuthenticateState.cpp b/server/states/src/AuthenticateState.cpp
index f04d813..95b1c08 100755 (executable)
--- a/server/states/src/AuthenticateState.cpp
+++ b/server/states/src/AuthenticateState.cpp
@@ -233,6 +233,12 @@ AuthenticateState::createStubRequestSign(AsmRequest *asmReq, const char *vTok)
                                        }
                                }
                                signAuthReq->khHList = g_list_first(signAuthReq->khHList);
+                               searchResIter = searchRes->begin();
+                               for (; searchResIter != searchRes->end(); ++searchResIter) {
+                                       delete *searchResIter;
+                               }
+                               searchRes->clear();
+                               delete searchRes;
                        }
                }
        }

diff --git a/silent_auth/silent_auth_entry.cpp b/silent_auth/silent_auth_entry.cpp
index 5ee52a9..2bd238f 100755 (executable)
--- a/silent_auth/silent_auth_entry.cpp
+++ b/silent_auth/silent_auth_entry.cpp
@@ -771,7 +771,7 @@ processRegister(unsigned char *assert_req)
 
        _INFO("After __create_raw_key_handle_string");
 
-       int kh_str_enc_len = 0;
+       unsigned int kh_str_enc_len = 0;
        unsigned char kh_str_enc[BIG_STRING_SIZE] = {0, };
        kh_str_enc_len = AsmCrypto::aesEncrypt((const unsigned char*)kh_str,
                                                                                                          strlen(kh_str),
@@ -877,6 +877,7 @@ processRegister(unsigned char *assert_req)
                SAFE_DELETE(krdStr);
                SAFE_DELETE(getRegRespInfo);
                SAFE_DELETE(priv_key_b64_enc);
+               SAFE_DELETE(keyId_b64_enc);
                return NULL;
        }