Fix Memory leak 78/260878/1 accepted/tizen/unified/20210707.070856 submit/tizen/20210706.080658
authorkiso.chang <kiso.chang@samsung.com>
Tue, 6 Jul 2021 07:53:22 +0000 (16:53 +0900)
committerkiso.chang <kiso.chang@samsung.com>
Tue, 6 Jul 2021 07:54:48 +0000 (16:54 +0900)
- fix covirity issues

Change-Id: I1c8c7fe8bff14acb0c5acabea3c599a65cfd0fb3
Signed-off-by: kiso.chang <kiso.chang@samsung.com>
setting-display/src/setting-display-main.c

index c0da36405b4463352babd3ded85192f6a42ce5f9..c17e347895f9cde237cd0e288cc3ff73410507fc 100755 (executable)
@@ -58,6 +58,9 @@ static char *get_current_theme_str()
 {
        SETTING_TRACE_BEGIN;
 
+       if (!setting_display_theme_change_is_supported())
+               return (char *)g_strdup(_("IDS_ST_HEADER_UNAVAILABLE"));
+
        theme_loader_h tl_handle;
        int result = theme_loader_create(&tl_handle);
        if(result != THEME_MANAGER_ERROR_NONE){
@@ -687,13 +690,7 @@ static int setting_display_main_create(void *cb)
                        NULL);
 
        /* THEME */
-       char *pa_theme = "theme 1";
-       if (setting_display_theme_change_is_supported())
-               pa_theme = get_current_theme_str();
-       else
-               pa_theme = g_strdup(_("IDS_ST_HEADER_UNAVAILABLE"));
-
-
+       char *pa_theme = get_current_theme_str();
        ad->data_theme =
                setting_create_Gendial_field_def(
                                ad->md.genlist,
@@ -704,6 +701,7 @@ static int setting_display_main_create(void *cb)
                                0, KeyStr_Theme,
                                pa_theme,
                                NULL);
+       FREE(pa_theme);
 
        if (ad->data_theme) {
                if (!setting_display_theme_change_is_supported())