eldbus: simplify code by using proper helper.
authorCedric BAIL <cedric@osg.samsung.com>
Fri, 23 Nov 2018 00:45:03 +0000 (16:45 -0800)
committerHermet Park <hermetpark@gmail.com>
Wed, 5 Dec 2018 05:52:40 +0000 (14:52 +0900)
efl_loop_promise_new is a helper function that does automatically figure out an
available scheduler and create a promise from it. Basically replacing the call to
eina_promise_new(efl_loop_future_scheduler_get(o), ...).

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Reviewed-by: Vitor Sousa da Silva <vitorsousa@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D7335

src/lib/eldbus/eldbus_model_connection.c
src/lib/eldbus/eldbus_model_object.c
src/lib/eldbus/eldbus_model_proxy.c

index a2ed5d5..c58faaf 100644 (file)
@@ -70,8 +70,7 @@ _eldbus_model_connection_efl_model_children_slice_get(Eo *obj,
         return eina_future_resolved(efl_loop_future_scheduler_get(obj), v);
      }
 
-   p = eina_promise_new(efl_loop_future_scheduler_get(obj),
-                        _eldbus_eina_promise_cancel, NULL);
+   p = efl_loop_promise_new(obj, _eldbus_eina_promise_cancel, NULL);
 
    slice = calloc(1, sizeof (Eldbus_Children_Slice_Promise));
    slice->p = p;
index ece21cf..f910683 100644 (file)
@@ -127,8 +127,7 @@ _eldbus_model_object_efl_model_children_slice_get(Eo *obj EINA_UNUSED,
         return eina_future_resolved(efl_loop_future_scheduler_get(obj), v);
      }
 
-   p = eina_promise_new(efl_loop_future_scheduler_get(obj),
-                        _eldbus_eina_promise_cancel, NULL);
+   p = efl_loop_promise_new(obj, _eldbus_eina_promise_cancel, NULL);
 
    slice = calloc(1, sizeof(struct _Eldbus_Children_Slice_Promise));
    slice->p = p;
index 96505ca..073baef 100644 (file)
@@ -293,8 +293,7 @@ _eldbus_model_proxy_efl_model_property_set(Eo *obj EINA_UNUSED,
    if (!data) goto on_error;
 
    data->pd = pd;
-   data->promise = eina_promise_new(efl_loop_future_scheduler_get(obj),
-                                    _eldbus_model_proxy_cancel_cb, data);
+   data->promise = efl_loop_promise_new(obj, _eldbus_model_proxy_cancel_cb, data);
    data->property = eina_stringshare_add(property);
    if (!(data->value = eina_value_dup(value))) goto on_error;