usb: host: ohci-pxa27x: Fix and & vs | typo
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 17 Aug 2019 06:55:20 +0000 (09:55 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Aug 2019 16:59:30 +0000 (09:59 -0700)
The code is supposed to clear the RH_A_NPS and RH_A_PSM bits, but it's
a no-op because of the & vs | typo.  This bug predates git and it was
only discovered using static analysis so it must not affect too many
people in real life.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20190817065520.GA29951@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ohci-pxa27x.c

index 3e24749597359108a723410be8e213961916b6aa..7679fb583e4161af1e7f624c841f2609c6865fe6 100644 (file)
@@ -148,7 +148,7 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode)
                uhcrhda |= RH_A_NPS;
                break;
        case PMM_GLOBAL_MODE:
-               uhcrhda &= ~(RH_A_NPS & RH_A_PSM);
+               uhcrhda &= ~(RH_A_NPS | RH_A_PSM);
                break;
        case PMM_PERPORT_MODE:
                uhcrhda &= ~(RH_A_NPS);