Bluetooth: Delete an unnecessary check before the function call "kfree_skb"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 14 Nov 2015 21:00:27 +0000 (22:00 +0100)
committerMarcel Holtmann <marcel@holtmann.org>
Thu, 19 Nov 2015 16:50:32 +0000 (17:50 +0100)
The kfree_skb() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/bluetooth/cmtp/core.c

index 298ed37..9e59b66 100644 (file)
@@ -178,8 +178,7 @@ static inline int cmtp_recv_frame(struct cmtp_session *session, struct sk_buff *
                        cmtp_add_msgpart(session, id, skb->data + hdrlen, len);
                        break;
                default:
-                       if (session->reassembly[id] != NULL)
-                               kfree_skb(session->reassembly[id]);
+                       kfree_skb(session->reassembly[id]);
                        session->reassembly[id] = NULL;
                        break;
                }