RDMA/qedr: clean up work queue on failure in qedr_alloc_resources()

[ Upstream commit 7a47e077e503feb73d56e491ce89aa73b67a3972 ]

Add a check for if create_singlethread_workqueue() fails and also destroy
the work queue on failure paths.

Fixes: e411e0587e0d ("RDMA/qedr: Add iWARP connection management functions")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/Y1gBkDucQhhWj5YM@kili
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c
index 755930b..6b59f97 100644 (file)
--- a/drivers/infiniband/hw/qedr/main.c
+++ b/drivers/infiniband/hw/qedr/main.c
@@ -345,6 +345,10 @@ static int qedr_alloc_resources(struct qedr_dev *dev)
        if (IS_IWARP(dev)) {
                xa_init(&dev->qps);
                dev->iwarp_wq = create_singlethread_workqueue("qedr_iwarpq");
+               if (!dev->iwarp_wq) {
+                       rc = -ENOMEM;
+                       goto err1;
+               }
        }
 
        /* Allocate Status blocks for CNQ */
@@ -352,7 +356,7 @@ static int qedr_alloc_resources(struct qedr_dev *dev)
                                GFP_KERNEL);
        if (!dev->sb_array) {
                rc = -ENOMEM;
-               goto err1;
+               goto err_destroy_wq;
        }
 
        dev->cnq_array = kcalloc(dev->num_cnq,
@@ -403,6 +407,9 @@ err3:
        kfree(dev->cnq_array);
 err2:
        kfree(dev->sb_array);
+err_destroy_wq:
+       if (IS_IWARP(dev))
+               destroy_workqueue(dev->iwarp_wq);
 err1:
        kfree(dev->sgid_tbl);
        return rc;