Yet another perf-o-matic build fix. It turns out that a task of the same name can...

queued for days after the first task is completed. So don't use it. Updating persistent
caches more often than necessary is better than never updating them.

* Websites/webkit-perf.appspot.com/controller.py:
(schedule_manifest_update):
(schedule_dashboard_update):
(schedule_runs_update):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/ChangeLog b/ChangeLog
index 6b7034b..3e6a709 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2012-02-13  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Yet another perf-o-matic build fix. It turns out that a task of the same name can't be
+        queued for days after the first task is completed. So don't use it. Updating persistent
+        caches more often than necessary is better than never updating them.
+
+        * Websites/webkit-perf.appspot.com/controller.py:
+        (schedule_manifest_update):
+        (schedule_dashboard_update):
+        (schedule_runs_update):
+
 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
 
         [GTK] Revise configuration for MHTML

diff --git a/Websites/webkit-perf.appspot.com/controller.py b/Websites/webkit-perf.appspot.com/controller.py
index 8e4e84c..42092fe 100644 (file)
--- a/Websites/webkit-perf.appspot.com/controller.py
+++ b/Websites/webkit-perf.appspot.com/controller.py
@@ -64,10 +64,7 @@ def cache_manifest(cache):
 
 
 def schedule_manifest_update():
-    try:
-        taskqueue.add(url='/api/test/update', name='manifest_update')
-    except taskqueue.TombstonedTaskError:
-        pass
+    taskqueue.add(url='/api/test/update')
 
 
 class CachedManifestHandler(webapp2.RequestHandler):
@@ -85,10 +82,7 @@ def cache_dashboard(cache):
 
 
 def schedule_dashboard_update():
-    try:
-        taskqueue.add(url='/api/test/dashboard/update', name='dashboard_update')
-    except taskqueue.TombstonedTaskError:
-        pass
+    taskqueue.add(url='/api/test/dashboard/update')
 
 
 class CachedDashboardHandler(webapp2.RequestHandler):
@@ -106,11 +100,7 @@ def cache_runs(test_id, branch_id, platform_id, cache):
 
 
 def schedule_runs_update(test_id, branch_id, platform_id):
-    try:
-        taskqueue.add(url='/api/test/runs/update', name='runs_update_%d_%d_%d' % (test_id, branch_id, platform_id),
-            params={'id': test_id, 'branchid': branch_id, 'platformid': platform_id})
-    except taskqueue.TombstonedTaskError:
-        pass
+    taskqueue.add(url='/api/test/runs/update', params={'id': test_id, 'branchid': branch_id, 'platformid': platform_id})
 
 
 class CachedRunsHandler(webapp2.RequestHandler):