Fix coverity issue (Unchecked return value)

[Version] 0.2.48
[Issue Type] Fix bugs

Change-Id: I15dbdc10a4f81fd9f748ab89a40444757bcd3ff4

diff --git a/packaging/libmm-radio.spec b/packaging/libmm-radio.spec
index f5e874806963b0c590f8503b49420710e2ae1c8d..5d368ab28925ef4ffa207a37d3bd139ca019d825 100644 (file)
--- a/packaging/libmm-radio.spec
+++ b/packaging/libmm-radio.spec
@@ -1,6 +1,6 @@
 Name:       libmm-radio
 Summary:    Multimedia Framework Radio Library
-Version:    0.2.47
+Version:    0.2.48
 Release:    0
 Group:      System/Libraries
 License:    Apache-2.0

diff --git a/src/mm_radio_priv_hal.c b/src/mm_radio_priv_hal.c
index c26be9a855adea5d3287796c99564eea00985f5e..b4d5f6ed2893b7ef44ca226c06cdaad6bbc9152b 100644 (file)
--- a/src/mm_radio_priv_hal.c
+++ b/src/mm_radio_priv_hal.c
@@ -321,13 +321,11 @@ int _mmradio_realize(mm_radio_t *radio)
        ret = sound_manager_create_stream_information_internal(SOUND_STREAM_TYPE_RADIO, NULL, radio, &radio->stream_info);
        if (ret != MM_ERROR_NONE) {
                MMRADIO_LOG_ERROR("failed to create stream information");
-               MMRADIO_LOG_FLEAVE();
                return ret;
        }
        ret = sound_manager_create_virtual_stream(radio->stream_info, &radio->vstream);
        if (ret != MM_ERROR_NONE) {
                MMRADIO_LOG_ERROR("sound_manager_create_virtual_stream error");
-               MMRADIO_LOG_FLEAVE();
                return ret;
        }
 
@@ -348,17 +346,29 @@ int _mmradio_unrealize(mm_radio_t *radio)
        MMRADIO_CHECK_STATE_RETURN_IF_FAIL(radio, MMRADIO_COMMAND_UNREALIZE);
 
        /*Finish if there are scans*/
-       _mmradio_stop_scan(radio);
+       ret = _mmradio_stop_scan(radio);
+       if (ret != MM_ERROR_NONE)
+               MMRADIO_LOG_WARNING("failed to stop radio scan");
 
        /*Stop radio if started*/
-       _mmradio_stop(radio);
+       ret = _mmradio_stop(radio);
+       if (ret != MM_ERROR_NONE)
+               MMRADIO_LOG_WARNING("failed to stop radio");
 
        if (radio->vstream) {
-               sound_manager_destroy_virtual_stream(radio->vstream);
+               ret = sound_manager_destroy_virtual_stream(radio->vstream);
+               if (ret != SOUND_MANAGER_ERROR_NONE) {
+                       MMRADIO_LOG_WARNING("failed to destory virtual stream information");
+                       return MM_ERROR_RADIO_INTERNAL;
+               }
                radio->vstream = NULL;
        }
        if (radio->stream_info) {
-               sound_manager_destroy_stream_information(radio->stream_info);
+               ret = sound_manager_destroy_stream_information(radio->stream_info);
+               if (ret != SOUND_MANAGER_ERROR_NONE) {
+                       MMRADIO_LOG_WARNING("failed to destory virtual stream information");
+                       return MM_ERROR_RADIO_INTERNAL;
+               }
                radio->stream_info = NULL;
        }
 
@@ -738,7 +748,7 @@ int _mmradio_seek(mm_radio_t *radio, MMRadioSeekDirectionType direction)
 
        MMRADIO_THREAD_LOCK(p_thread);
 
-       MMRADIO_LOG_INFO("trying to seek. direction[0:UP/1:DOWN) %d", direction);
+       MMRADIO_LOG_INFO("trying to seek. direction [%s]", direction ? "DOWN" : "UP");
        radio->seek_direction = direction;
        p_thread->is_running = true;
        p_thread->stop = false;