disable accelerator when menu item is disabled
authorliusi <siyuan.liu@autodesk.com>
Mon, 14 Nov 2016 04:29:27 +0000 (12:29 +0800)
committerliusi <siyuan.liu@autodesk.com>
Mon, 14 Nov 2016 04:29:27 +0000 (12:29 +0800)
atom/browser/ui/accelerator_util.cc

index eb89bf0..a7877a9 100644 (file)
@@ -90,11 +90,12 @@ bool TriggerAcceleratorTableCommand(AcceleratorTable* table,
                                     const ui::Accelerator& accelerator) {
   if (ContainsKey(*table, accelerator)) {
     const accelerator_util::MenuItem& item = (*table)[accelerator];
-    item.model->ActivatedAt(item.position);
-    return true;
-  } else {
-    return false;
+    if (item.model->IsEnabledAt(item.position)) {
+      item.model->ActivatedAt(item.position);
+      return true;
+    } 
   }
+  return false;
 }
 
 }  // namespace accelerator_util