drm/i915: Add missing commas to dbuf tables
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 25 Feb 2020 17:11:08 +0000 (19:11 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 2 Mar 2020 14:41:58 +0000 (16:41 +0200)
The preferred style is to sprinkle commas after each array and
structure initialization, whether or not it happens to be the
last element/member (only exception being sentinel entries which
never have anything after them). This leads to much prettier
diffs if/when new elements/members get added to the end of the
initialization. We're not bound by some ancient silly mandate
to omit the final comma.

Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225171125.28885-4-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/intel_pm.c

index cdc02b6..be24969 100644 (file)
@@ -4174,49 +4174,49 @@ static const struct dbuf_slice_conf_entry icl_allowed_dbufs[] =
        {
                .active_pipes = BIT(PIPE_A),
                .dbuf_mask = {
-                       [PIPE_A] = BIT(DBUF_S1)
-               }
+                       [PIPE_A] = BIT(DBUF_S1),
+               },
        },
        {
                .active_pipes = BIT(PIPE_B),
                .dbuf_mask = {
-                       [PIPE_B] = BIT(DBUF_S1)
-               }
+                       [PIPE_B] = BIT(DBUF_S1),
+               },
        },
        {
                .active_pipes = BIT(PIPE_A) | BIT(PIPE_B),
                .dbuf_mask = {
                        [PIPE_A] = BIT(DBUF_S1),
-                       [PIPE_B] = BIT(DBUF_S2)
-               }
+                       [PIPE_B] = BIT(DBUF_S2),
+               },
        },
        {
                .active_pipes = BIT(PIPE_C),
                .dbuf_mask = {
-                       [PIPE_C] = BIT(DBUF_S2)
-               }
+                       [PIPE_C] = BIT(DBUF_S2),
+               },
        },
        {
                .active_pipes = BIT(PIPE_A) | BIT(PIPE_C),
                .dbuf_mask = {
                        [PIPE_A] = BIT(DBUF_S1),
-                       [PIPE_C] = BIT(DBUF_S2)
-               }
+                       [PIPE_C] = BIT(DBUF_S2),
+               },
        },
        {
                .active_pipes = BIT(PIPE_B) | BIT(PIPE_C),
                .dbuf_mask = {
                        [PIPE_B] = BIT(DBUF_S1),
-                       [PIPE_C] = BIT(DBUF_S2)
-               }
+                       [PIPE_C] = BIT(DBUF_S2),
+               },
        },
        {
                .active_pipes = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C),
                .dbuf_mask = {
                        [PIPE_A] = BIT(DBUF_S1),
                        [PIPE_B] = BIT(DBUF_S1),
-                       [PIPE_C] = BIT(DBUF_S2)
-               }
+                       [PIPE_C] = BIT(DBUF_S2),
+               },
        },
 };
 
@@ -4236,100 +4236,100 @@ static const struct dbuf_slice_conf_entry tgl_allowed_dbufs[] =
        {
                .active_pipes = BIT(PIPE_A),
                .dbuf_mask = {
-                       [PIPE_A] = BIT(DBUF_S1) | BIT(DBUF_S2)
-               }
+                       [PIPE_A] = BIT(DBUF_S1) | BIT(DBUF_S2),
+               },
        },
        {
                .active_pipes = BIT(PIPE_B),
                .dbuf_mask = {
-                       [PIPE_B] = BIT(DBUF_S1) | BIT(DBUF_S2)
-               }
+                       [PIPE_B] = BIT(DBUF_S1) | BIT(DBUF_S2),
+               },
        },
        {
                .active_pipes = BIT(PIPE_A) | BIT(PIPE_B),
                .dbuf_mask = {
                        [PIPE_A] = BIT(DBUF_S2),
-                       [PIPE_B] = BIT(DBUF_S1)
-               }
+                       [PIPE_B] = BIT(DBUF_S1),
+               },
        },
        {
                .active_pipes = BIT(PIPE_C),
                .dbuf_mask = {
-                       [PIPE_C] = BIT(DBUF_S2) | BIT(DBUF_S1)
-               }
+                       [PIPE_C] = BIT(DBUF_S2) | BIT(DBUF_S1),
+               },
        },
        {
                .active_pipes = BIT(PIPE_A) | BIT(PIPE_C),
                .dbuf_mask = {
                        [PIPE_A] = BIT(DBUF_S1),
-                       [PIPE_C] = BIT(DBUF_S2)
-               }
+                       [PIPE_C] = BIT(DBUF_S2),
+               },
        },
        {
                .active_pipes = BIT(PIPE_B) | BIT(PIPE_C),
                .dbuf_mask = {
                        [PIPE_B] = BIT(DBUF_S1),
-                       [PIPE_C] = BIT(DBUF_S2)
-               }
+                       [PIPE_C] = BIT(DBUF_S2),
+               },
        },
        {
                .active_pipes = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C),
                .dbuf_mask = {
                        [PIPE_A] = BIT(DBUF_S1),
                        [PIPE_B] = BIT(DBUF_S1),
-                       [PIPE_C] = BIT(DBUF_S2)
-               }
+                       [PIPE_C] = BIT(DBUF_S2),
+               },
        },
        {
                .active_pipes = BIT(PIPE_D),
                .dbuf_mask = {
-                       [PIPE_D] = BIT(DBUF_S2) | BIT(DBUF_S1)
-               }
+                       [PIPE_D] = BIT(DBUF_S2) | BIT(DBUF_S1),
+               },
        },
        {
                .active_pipes = BIT(PIPE_A) | BIT(PIPE_D),
                .dbuf_mask = {
                        [PIPE_A] = BIT(DBUF_S1),
-                       [PIPE_D] = BIT(DBUF_S2)
-               }
+                       [PIPE_D] = BIT(DBUF_S2),
+               },
        },
        {
                .active_pipes = BIT(PIPE_B) | BIT(PIPE_D),
                .dbuf_mask = {
                        [PIPE_B] = BIT(DBUF_S1),
-                       [PIPE_D] = BIT(DBUF_S2)
-               }
+                       [PIPE_D] = BIT(DBUF_S2),
+               },
        },
        {
                .active_pipes = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_D),
                .dbuf_mask = {
                        [PIPE_A] = BIT(DBUF_S1),
                        [PIPE_B] = BIT(DBUF_S1),
-                       [PIPE_D] = BIT(DBUF_S2)
-               }
+                       [PIPE_D] = BIT(DBUF_S2),
+               },
        },
        {
                .active_pipes = BIT(PIPE_C) | BIT(PIPE_D),
                .dbuf_mask = {
                        [PIPE_C] = BIT(DBUF_S1),
-                       [PIPE_D] = BIT(DBUF_S2)
-               }
+                       [PIPE_D] = BIT(DBUF_S2),
+               },
        },
        {
                .active_pipes = BIT(PIPE_A) | BIT(PIPE_C) | BIT(PIPE_D),
                .dbuf_mask = {
                        [PIPE_A] = BIT(DBUF_S1),
                        [PIPE_C] = BIT(DBUF_S2),
-                       [PIPE_D] = BIT(DBUF_S2)
-               }
+                       [PIPE_D] = BIT(DBUF_S2),
+               },
        },
        {
                .active_pipes = BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D),
                .dbuf_mask = {
                        [PIPE_B] = BIT(DBUF_S1),
                        [PIPE_C] = BIT(DBUF_S2),
-                       [PIPE_D] = BIT(DBUF_S2)
-               }
+                       [PIPE_D] = BIT(DBUF_S2),
+               },
        },
        {
                .active_pipes = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D),
@@ -4337,8 +4337,8 @@ static const struct dbuf_slice_conf_entry tgl_allowed_dbufs[] =
                        [PIPE_A] = BIT(DBUF_S1),
                        [PIPE_B] = BIT(DBUF_S1),
                        [PIPE_C] = BIT(DBUF_S2),
-                       [PIPE_D] = BIT(DBUF_S2)
-               }
+                       [PIPE_D] = BIT(DBUF_S2),
+               },
        },
 };