ima: Fix potential memory leak in ima_init_crypto()
authorJianglei Nie <niejianglei2021@163.com>
Tue, 12 Jul 2022 01:10:37 +0000 (09:10 +0800)
committerMimi Zohar <zohar@linux.ibm.com>
Wed, 13 Jul 2022 14:13:58 +0000 (10:13 -0400)
On failure to allocate the SHA1 tfm, IMA fails to initialize and exits
without freeing the ima_algo_array. Add the missing kfree() for
ima_algo_array to avoid the potential memory leak.

Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Fixes: 6d94809af6b0 ("ima: Allocate and initialize tfm for each PCR bank")
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
security/integrity/ima/ima_crypto.c

index a7206cc1d7d19129e6511a93f7452e1a9fa4287d..64499056648ad112b00c631df48d4f58e7788601 100644 (file)
@@ -205,6 +205,7 @@ out_array:
 
                crypto_free_shash(ima_algo_array[i].tfm);
        }
+       kfree(ima_algo_array);
 out:
        crypto_free_shash(ima_shash_tfm);
        return rc;