greybus: firmware: s/should/must
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 11 Aug 2016 20:27:24 +0000 (13:27 -0700)
committerGreg Kroah-Hartman <gregkh@google.com>
Fri, 12 Aug 2016 15:38:19 +0000 (17:38 +0200)
Replace 'should' with 'must' to clear the expectation a bit more.

Reported-by: Alex Elder <alex.elder@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/fw-download.c

index 1c63256..2d72468 100644 (file)
@@ -238,7 +238,7 @@ static int fw_download_find_firmware(struct gb_operation *op)
        request = op->request->payload;
        tag = (const char *)request->firmware_tag;
 
-       /* firmware_tag should be null-terminated */
+       /* firmware_tag must be null-terminated */
        if (strnlen(tag, GB_FIRMWARE_TAG_MAX_SIZE) == GB_FIRMWARE_TAG_MAX_SIZE) {
                dev_err(fw_download->parent,
                        "firmware-tag is not null-terminated\n");