mctp: Reorder fields in 'struct mctp_route'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 18 Jun 2023 09:33:55 +0000 (11:33 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 21 Jun 2023 03:06:16 +0000 (20:06 -0700)
Group some variables based on their sizes to reduce hole and avoid padding.
On x86_64, this shrinks the size of 'struct mctp_route'
from 72 to 64 bytes.

It saves a few bytes of memory and is more cache-line friendly.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Jeremy Kerr <jk@codeconstruct.com.au>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/393ad1a5aef0aa28d839eeb3d7477da0e0eeb0b0.1687080803.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/mctp.h

index 82800d5..da86e10 100644 (file)
@@ -234,9 +234,9 @@ struct mctp_flow {
 struct mctp_route {
        mctp_eid_t              min, max;
 
-       struct mctp_dev         *dev;
-       unsigned int            mtu;
        unsigned char           type;
+       unsigned int            mtu;
+       struct mctp_dev         *dev;
        int                     (*output)(struct mctp_route *route,
                                          struct sk_buff *skb);