gltestsrc: Fix potential NULL pointer dereference if we fail without GError
authorSebastian Dröge <sebastian@centricular.com>
Tue, 28 Feb 2017 13:22:43 +0000 (15:22 +0200)
committerSebastian Dröge <sebastian@centricular.com>
Tue, 28 Feb 2017 13:23:55 +0000 (15:23 +0200)
Which can happen here if we just propagate an error that happened
elsewhere, e.g. FBO failed.

CID 1364604

ext/gl/gstgltestsrc.c

index 51c709d..83218b4 100644 (file)
@@ -675,9 +675,13 @@ unsupported_gl_api:
   }
 context_error:
   {
-    GST_ELEMENT_ERROR (src, RESOURCE, NOT_FOUND, ("%s", error->message),
-        (NULL));
-    g_clear_error (&error);
+    if (error) {
+      GST_ELEMENT_ERROR (src, RESOURCE, NOT_FOUND, ("%s", error->message),
+          (NULL));
+      g_clear_error (&error);
+    } else {
+      GST_ELEMENT_ERROR (src, RESOURCE, NOT_FOUND, (NULL), (NULL));
+    }
     if (src->context)
       gst_object_unref (src->context);
     src->context = NULL;