fbdev: goldfishfb: Do not check 0 for platform_get_irq()
authorZhu Wang <wangzhu9@huawei.com>
Thu, 3 Aug 2023 07:10:06 +0000 (15:10 +0800)
committerHelge Deller <deller@gmx.de>
Tue, 15 Aug 2023 21:39:33 +0000 (23:39 +0200)
Since platform_get_irq() never returned zero, so it need not to check
whether it returned zero, and we use the return error code of
platform_get_irq() to replace the current return error code.

Please refer to the commit a85a6c86c25b ("driver core: platform: Clarify
that IRQ 0 is invalid") to get that platform_get_irq() never returned
zero.

Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/goldfishfb.c

index 6fa2108..e41c9fe 100644 (file)
@@ -203,8 +203,8 @@ static int goldfish_fb_probe(struct platform_device *pdev)
        }
 
        fb->irq = platform_get_irq(pdev, 0);
-       if (fb->irq <= 0) {
-               ret = -ENODEV;
+       if (fb->irq < 0) {
+               ret = fb->irq;
                goto err_no_irq;
        }