Fix coverity issue (copy data during iteration)

Change-Id: I629a029f987242addf7bf69ec5b3a4af34f0226d

diff --git a/libaurum/src/Impl/Accessibility/AtspiAccessibleWatcher.cc b/libaurum/src/Impl/Accessibility/AtspiAccessibleWatcher.cc
index 8684f55..81cdb20 100644 (file)
--- a/libaurum/src/Impl/Accessibility/AtspiAccessibleWatcher.cc
+++ b/libaurum/src/Impl/Accessibility/AtspiAccessibleWatcher.cc
@@ -575,7 +575,7 @@ void AtspiAccessibleWatcher::setXMLsync(bool sync)
         mAppXMLLoadedCount = 0;
     } else {
         auto apps = getApplications();
-        for (auto app : apps)
+        for (auto &app : apps)
         {
             app->getAccessibleNode()->updateName();
             mAppCount++;

diff --git a/libaurum/src/Impl/MockDeviceImpl.cc b/libaurum/src/Impl/MockDeviceImpl.cc
index 6c72a24..db933f4 100644 (file)
--- a/libaurum/src/Impl/MockDeviceImpl.cc
+++ b/libaurum/src/Impl/MockDeviceImpl.cc
@@ -272,7 +272,7 @@ std::vector<std::shared_ptr<AccessibleNode>> MockDeviceImpl::getWindowRoot() con
 
     auto apps = AccessibleWatcher::getInstance()->getApplications();
 
-    for (auto app : apps)
+    for (auto &app : apps)
     {
         auto wins = app->getWindows();
         std::transform(wins.begin(), wins.end(), std::back_inserter(ret),

diff --git a/libaurum/src/Impl/TizenDeviceImpl.cc b/libaurum/src/Impl/TizenDeviceImpl.cc
index bd29ad2..c99b130 100644 (file)
--- a/libaurum/src/Impl/TizenDeviceImpl.cc
+++ b/libaurum/src/Impl/TizenDeviceImpl.cc
@@ -448,7 +448,7 @@ std::vector<std::shared_ptr<AccessibleNode>> TizenDeviceImpl::getWindowRoot() co
     std::unordered_map<int, std::shared_ptr<AccessibleApplication>> pidToAppNode{};
 
     auto apps = AccessibleWatcher::getInstance()->getApplications();
-    for (auto app : apps)
+    for (auto &app : apps)
     {
         app->getAccessibleNode()->updateName();
         app->getAccessibleNode()->updatePid();
@@ -457,7 +457,7 @@ std::vector<std::shared_ptr<AccessibleNode>> TizenDeviceImpl::getWindowRoot() co
         pidToAppNode[app->getAccessibleNode()->getPid()] = app;
     }
 
-    for (auto tWin : mTizenWindows)
+    for (auto &tWin : mTizenWindows)
     {
         LOGI("Visible win (%d) (%d %d %d %d) (%s)", tWin->getPid(), tWin->getWindowGeometry().mTopLeft.x, tWin->getWindowGeometry().mTopLeft.y, tWin->getWindowGeometry().width(),
             tWin->getWindowGeometry().height(), tWin->getName().c_str());