win/msi: don't create empty npm folder in %appdata%
authorBert Belder <bertbelder@gmail.com>
Wed, 6 Mar 2013 14:41:12 +0000 (15:41 +0100)
committerBert Belder <bertbelder@gmail.com>
Fri, 8 Mar 2013 17:00:35 +0000 (18:00 +0100)
Npm creates this folder when it's needed. Creating it in the installer
violates the per-user / per-machine scope separation.

tools/msvs/msi/product.wxs

index 0bb5dfb..905b506 100755 (executable)
           </Component>
         </Directory>
       </Directory>
-
-      <Directory Id="AppDataFolder">
-        <Directory Id="NPMAppData" Name="npm">
-          <Component Id="npmappdata_folder" Guid="994B1F7F-60CD-4792-A96D-63BC7FFF29BF" Permanent="yes">
-            <RegistryKey Key="dummy" Root="HKCU" >
-              <RegistryValue Type="integer"  Value="1" KeyPath="yes" />
-            </RegistryKey >
-            <CreateFolder/>
-            <RemoveFolder Id="RemoveAppData" On="uninstall" />
-          </Component>
-        </Directory>
-      </Directory>
     </Directory>
 
     <DirectoryRef Id="ApplicationProgramsFolder">
       <ComponentRef Id="npmcmd"/>
       <ComponentRef Id="npmsh"/>
       <ComponentRef Id="npmrc" />
-      <ComponentRef Id="npmappdata_folder" />
       <ComponentGroupRef Id="NPMFiles" />
       <ComponentRef Id="nodejsvars" />
       <ComponentRef Id="noderegistry" />