Plug input fd leak.
authorjbj <devnull@localhost>
Sun, 11 Oct 1998 21:43:10 +0000 (21:43 +0000)
committerjbj <devnull@localhost>
Sun, 11 Oct 1998 21:43:10 +0000 (21:43 +0000)
CVS patchset: 2447
CVS date: 1998/10/11 21:43:10

tools/rpmgettext.c

index 830a7bc..ad98ed3 100644 (file)
@@ -729,16 +729,22 @@ rewriteBinaryRPM(char *fni, char *fno, message_list_ty *mlp)
 
     /* Inject new strings into header tags */
     if ((rc = headerInject(spec->packages->header, poTags, mlp)) != 0)
-       return rc;
+       goto exit;
 
     /* Rewrite the rpm */
     if (lead.type == RPMLEAD_SOURCE) {
-       return writeRPM(spec->packages->header, fno, (int)lead.type,
+       rc = writeRPM(spec->packages->header, fno, (int)lead.type,
                csa, spec->passPhrase, &(spec->cookie));
     } else {
-       return writeRPM(spec->packages->header, fno, (int)lead.type,
+       rc = writeRPM(spec->packages->header, fno, (int)lead.type,
                csa, spec->passPhrase, NULL);
     }
+
+exit:
+    if (csa->cpioFdIn >= 0)
+       close(csa->cpioFdIn);
+    return rc;
+
 }
 
 /* ================================================================== */