BACKPORT: Fix a bidirectional UDS connect check typo

The 54e70ec5eb090193b03e69d551fa6771a5a217c4 commit introduced a
bidirectional check that should have checked for mutual WRITE access
between two labels. Due to a typo the second check was incorrect.

Signed-off-by: Lukasz Pawelczyk <l.pawelczyk@samsung.com>
(cherry-picked from upstream d01757904d9deb619e23c9450218829943a46822)

diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 98e0dd704988d4fdf2cf05d03ec45ac89b226b67..366d0f20f3810814305ecf470ec741bc7d141959 100644 (file)
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -3305,8 +3305,8 @@ static int smack_unix_stream_connect(struct sock *sock,
                rc = smk_bu_note("UDS connect", skp, okp->smk_known,
                                        MAY_WRITE, rc);
                if (rc == 0) {
-                       rc = smk_access(okp, okp->smk_known, MAY_WRITE, NULL);
-                       rc = smk_bu_note("UDS connect", okp, okp->smk_known,
+                       rc = smk_access(okp, skp->smk_known, MAY_WRITE, NULL);
+                       rc = smk_bu_note("UDS connect", okp, skp->smk_known,
                                                MAY_WRITE, rc);
                }
        }