ASoC: codecs: Fix unsigned comparison with less than zero
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Mon, 6 Feb 2023 07:55:18 +0000 (15:55 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 6 Feb 2023 13:12:36 +0000 (13:12 +0000)
The val is defined as unsigned int type, if(val<0) is redundant, so
delete it.

sound/soc/codecs/idt821034.c:449 idt821034_kctrl_gain_put() warn: unsigned 'val' is never less than zero.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3947
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Herve Codina <herve.codina@bootlin.com>
Link: https://lore.kernel.org/r/20230206075518.84169-1-jiapeng.chong@linux.alibaba.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/idt821034.c

index 5d01787..2cc7b91 100644 (file)
@@ -446,8 +446,6 @@ static int idt821034_kctrl_gain_put(struct snd_kcontrol *kcontrol,
        u8 ch;
 
        val = ucontrol->value.integer.value[0];
-       if (val < 0)
-               return -EINVAL;
        if (val > max - min)
                return -EINVAL;