rtw88: wow: build wow function only if CONFIG_PM is on
authorPing-Ke Shih <pkshih@realtek.com>
Wed, 28 Jul 2021 01:43:33 +0000 (09:43 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 21 Aug 2021 19:19:15 +0000 (22:19 +0300)
The kernel test robot reports undefined reference after we report wakeup
reason to mac80211. This is because CONFIG_PM is not defined in the testing
configuration file. In fact, functions within wow.c are used if CONFIG_PM
is defined, so use CONFIG_PM to decide whether we build this file or not.

The reported messages are:
   hppa-linux-ld: drivers/net/wireless/realtek/rtw88/wow.o: in function `rtw_wow_show_wakeup_reason':
>> (.text+0x6c4): undefined reference to `ieee80211_report_wowlan_wakeup'
>> hppa-linux-ld: (.text+0x6e0): undefined reference to `ieee80211_report_wowlan_wakeup'

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210728014335.8785-4-pkshih@realtek.com
drivers/net/wireless/realtek/rtw88/Makefile

index c0e4b11..73d6807 100644 (file)
@@ -15,9 +15,9 @@ rtw88_core-y += main.o \
           ps.o \
           sec.o \
           bf.o \
-          wow.o \
           regd.o
 
+rtw88_core-$(CONFIG_PM) += wow.o
 
 obj-$(CONFIG_RTW88_8822B)      += rtw88_8822b.o
 rtw88_8822b-objs               := rtw8822b.o rtw8822b_table.o