staging: mt7621-mmc: Remove multiple assignments
authorChristian Lütke-Stetzkamp <christian@lkamp.de>
Tue, 24 Apr 2018 18:01:23 +0000 (20:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Apr 2018 13:36:19 +0000 (15:36 +0200)
Fix checkpatch: multiple assignments should be avoided, to improve
readability.
It aslo moves the second assignment out of the if/else block, that is
valid, because drv_mode is of type msdc_mode, an enum with only those
three elements, so one of the if/ else if statements is always
taken. And the second assignment can happen after the conditions.

Signed-off-by: Christian Lütke-Stetzkamp <christian@lkamp.de>
Reviewed-by: NeilBrown <neil@brown.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/mt7621-mmc/sd.c

index a3e2c97..d464e2a 100644 (file)
@@ -1397,11 +1397,12 @@ static int msdc_do_request(struct mmc_host *mmc, struct mmc_request *mrq)
 
                /* deside the transfer mode */
                if (drv_mode[host->id] == MODE_PIO)
-                       host->dma_xfer = dma = 0;
+                       host->dma_xfer = 0;
                else if (drv_mode[host->id] == MODE_DMA)
-                       host->dma_xfer = dma = 1;
+                       host->dma_xfer = 1;
                else if (drv_mode[host->id] == MODE_SIZE_DEP)
-                       host->dma_xfer = dma = ((host->xfer_size >= dma_size[host->id]) ? 1 : 0);
+                       host->dma_xfer = ((host->xfer_size >= dma_size[host->id]) ? 1 : 0);
+               dma = host->dma_xfer;
 
                if (read) {
                        if ((host->timeout_ns != data->timeout_ns) ||